Skip to content

Try to fix dependabot PRs #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2023
Merged

Conversation

elliette
Copy link
Contributor

@elliette elliette commented May 12, 2023

The dependabot PRs update the dart.yaml file, which is generated by mono_repo generate. That means for every dependabot PR, the mono_repo validate step fails (dart.yaml no longer matches what it would be if it were generated).

See #2104 for example

Therefore the dependabot PRs should not update the dart.yaml file.

@elliette elliette requested a review from annagrin May 12, 2023 17:01
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 12, 2023
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 2b2ae0e into dart-lang:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants